lkml.org 
[lkml]   [2009]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mmc: align data size for host which only supports power-of-2 block
On Thu, 26 Mar 2009 10:22:54 +0800
"Cai, Cliff" <Cliff.Cai@analog.com> wrote:

> >
> >mmc_align_data_size() shouldn't be adjusting the size to something it
> >can easily determine that it's invalid.
>
> Should I create a new function to do the power-of-2 adjustment?
> Or any ideal way to do it?

That function is the correct place. My point was that we need to check
after the adjustment that we didn't violate any of the other
restrictions the driver has set. If we do, we should just return the
original value.

> Otherwise,the SDH almost can't be used as sdio host.

Unfortunately I think this controller will be very unsuitable as an
SDIO controller anyway with that restriction.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.


\
 
 \ /
  Last update: 2009-04-05 21:11    [W:0.107 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site