Messages in this thread | | | From | "Cai, Cliff" <> | Subject | RE: [PATCH] mmc: align data size for host which only supports power-of-2 block | Date | Thu, 26 Mar 2009 10:22:54 +0800 |
| |
>
>-----Original Message----- >From: Pierre Ossman [mailto:drzeus-mmc@drzeus.cx] >Sent: Thursday, March 26, 2009 3:24 AM >To: Cai, Cliff >Cc: Bryan Wu; linux-kernel@vger.kernel.org >Subject: Re: [PATCH] mmc: align data size for host which only >supports power-of-2 block > >On Wed, 25 Mar 2009 11:22:25 +0800 >"Cai, Cliff" <Cliff.Cai@analog.com> wrote: > >> > >> >This patch seems premature as there is no associated >modification of >> >any of the host drivers. >> >> The SDH on Blackfin BF54x/BF51x only supports power-of-2 block >> transfer,we will soon Send the sdh driver to mainline as well. >> > >Ok. Looking forward to it. :) > >> >Padding to a power of two size can also mean a rather large >> >padding. We might need to check the host data limits after >> >doing the adjustment. >> >> Yes,but it's the higher level driver's job. >> > >mmc_align_data_size() shouldn't be adjusting the size to something it >can easily determine that it's invalid.
Should I create a new function to do the power-of-2 adjustment? Or any ideal way to do it? Otherwise,the SDH almost can't be used as sdio host.
Thanks
Cliff
| |