lkml.org 
[lkml]   [2009]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
    On Thu, 23 Apr 2009 12:30:58 -0400
    Mike Frysinger <vapier.adi@gmail.com> wrote:

    >  for the blackfin you should just check if
    > >  you have locking issues in your irq routine
    >
    > the Blackfin driver calls rtc_update_irq() from its IRQ handler and
    > the handler is not registered with IRQF_DISABLED. it makes more sense
    > to me to fix rtc_update_irq() than require all RTC drivers to register
    > with IRQF_DISABLED. especially in my case as the Blackfin driver
    > itself doesnt need any locks.

    I agree. rtc_update_irq is not problematic by itself, it just takes
    locks that other parts of the driver should take appropriately.

    For example, if you take irq_lock with irqs enabled you
    will get in trouble. blackfin seems ok, for the other
    drivers we need to verify this.

    --

    Best regards,

    Alessandro Zummo,
    Tower Technologies - Torino, Italy

    http://www.towertech.it

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-23 18:43    [W:0.020 / U:60.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site