Messages in this thread | | | Date | Thu, 23 Apr 2009 12:30:58 -0400 | Subject | Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled | From | Mike Frysinger <> |
| |
On Thu, Apr 23, 2009 at 11:37, Alessandro Zummo wrote: > On Thu, 23 Apr 2009 11:07:38 -0400 Mike Frysinger wrote: >> we just removed the shared bit from the Blackfin rtc driver because it >> didnt really make sense for us. i need to test something else, so is >> the only change you need is the one posted originally ? that makes >> more sense to me than forcing everyone to use IRQF_DISABLED. > > for the blackfin you should just check if > you have locking issues in your irq routine
the Blackfin driver calls rtc_update_irq() from its IRQ handler and the handler is not registered with IRQF_DISABLED. it makes more sense to me to fix rtc_update_irq() than require all RTC drivers to register with IRQF_DISABLED. especially in my case as the Blackfin driver itself doesnt need any locks. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |