lkml.org 
[lkml]   [2009]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch] dereferencing freed in saa5249.c
I moved the kfree() down a couple lines.  t->vdev is going to be in freed 
memory so there is no point setting it to NULL. I added a kfree(t) on a
different error path.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/media/video/saa5249.c 2009-04-09 23:54:15.000000000 +0300
+++ devel/drivers/media/video/saa5249.c 2009-04-09 23:59:16.000000000 +0300
@@ -598,6 +598,7 @@
/* Now create a video4linux device */
t->vdev = video_device_alloc();
if (t->vdev == NULL) {
+ kfree(t);
kfree(client);
return -ENOMEM;
}
@@ -617,9 +618,8 @@
/* Register it */
err = video_register_device(t->vdev, VFL_TYPE_VTX, -1);
if (err < 0) {
- kfree(t);
video_device_release(t->vdev);
- t->vdev = NULL;
+ kfree(t);
return err;
}
return 0;

\
 
 \ /
  Last update: 2009-04-10 11:03    [W:0.053 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site