Messages in this thread Patch in this message | | | Subject | [PATCH] tracing/filters: disallow integer values for string filters and vice versa | From | Tom Zanussi <> | Date | Tue, 24 Mar 2009 02:14:42 -0500 |
| |
Make sure filters for string fields don't use integer values and vice versa. Getting it wrong can crash the system or produce bogus results.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
--- kernel/trace/trace_events_filter.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 9fca8bb..026be41 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -237,9 +237,14 @@ int filter_add_pred(struct ftrace_event_call *call, struct filter_pred *pred) pred->offset = field->offset; if (is_string_field(field->type)) { + if (!pred->str_val) + return -EINVAL; pred->fn = filter_pred_string; pred->str_len = field->size; return __filter_add_pred(call, pred); + } else { + if (pred->str_val) + return -EINVAL; } switch (field->size) { -- 1.5.6.3
| |