lkml.org 
[lkml]   [2009]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] cgroups: show correct file mode
KAMEZAWA Hiroyuki wrote:
> On Mon, 2 Mar 2009 16:15:51 -0800
> Paul Menage <menage@google.com> wrote:
>
>> On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki
>> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>>> int mode;
>>> if (cft->mode)
>>> mode = cft->mode;
>>> else if (cft->write_xxx || .....)
>>> mode = 0644;
>>> else
>>> mode = 0444;
>> Almost:
>>
>> int mode;
>> if (cft->mode) {
>> mode = cft->mode;
>> } else {
>> if (cft->write_xxx || ....)
>> mode |= 0600;

0200 ?

>> if (cft->read_xxx || ...)
>> mode |= 0444;
>> }
>>
> Oh, I see. But int mode=0, at first ;)
> I have no objections but please forgive subsys to set mode=0644 explicitly.
>
> Thanks,
> -Kame
>
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/containers



\
 
 \ /
  Last update: 2009-03-03 01:27    [W:0.049 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site