Messages in this thread |  | | | Date | Tue, 3 Mar 2009 09:20:21 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [PATCH 0/4] cgroups: show correct file mode |
| |
On Mon, 2 Mar 2009 16:15:51 -0800 Paul Menage <menage@google.com> wrote:
> On Mon, Mar 2, 2009 at 4:09 PM, KAMEZAWA Hiroyuki > <kamezawa.hiroyu@jp.fujitsu.com> wrote: > > > > int mode; > > if (cft->mode) > > mode = cft->mode; > > else if (cft->write_xxx || .....) > > mode = 0644; > > else > > mode = 0444; > > Almost: > > int mode; > if (cft->mode) { > mode = cft->mode; > } else { > if (cft->write_xxx || ....) > mode |= 0600; > if (cft->read_xxx || ...) > mode |= 0444; > } > Oh, I see. But int mode=0, at first ;) I have no objections but please forgive subsys to set mode=0644 explicitly.
Thanks, -Kame
|  |