lkml.org 
[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Q: NFSD readdir in linux-2.6.28
    From
    Date
    On Fri, 2009-03-20 at 00:34 +0900, hooanon05@yahoo.co.jp wrote:
    > If you remember why you discarded the FS_NO_LOOKUP_IN_READDIR flag
    > approach, please let me know. URL or something is enough.

    I was just lamenting that decision. I think someone persuaded me that
    the extra complexity wasn't worth it, and that we should just do it
    unconditionally.

    One option would be to restore the FS_NO_LOOKUP_IN_READDIR flag, and
    document that it means that your ->lookup is called _without_ i_mutex
    held. That would actually be OK in all cases that need the flag, I
    believe (since the whole point in those cases is that they have their
    _own_ locking which is why we did it in the first place).

    --
    David Woodhouse Open Source Technology Centre
    David.Woodhouse@intel.com Intel Corporation



    \
     
     \ /
      Last update: 2009-03-19 16:55    [W:0.021 / U:120.416 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site