[lkml]   [2009]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Q: NFSD readdir in linux-2.6.28

    David Woodhouse:
    > Yes, well spotted. It didn't matter when the buffered readdir() was
    > purely internal to XFS, because it didn't matter there that we called
    > ->lookup() without i_mutex set. But now we're exposing arbitrary file
    > systems to it, we need to make sure we follow the locking rules.
    > I _think_ it's sufficient to make the affected callers of
    > lookup_one_len() lock the parent's i_mutex for themselves before calling
    > it. I'll take a closer look...

    If you remember why you discarded the FS_NO_LOOKUP_IN_READDIR flag
    approach, please let me know. URL or something is enough.

    J. R. Okajima

     \ /
      Last update: 2009-03-19 16:39    [W:0.020 / U:8.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site