Messages in this thread Patch in this message | | | Date | Sat, 28 Feb 2009 18:17:47 +0300 | From | Cyrill Gorcunov <> | Subject | [PATCH] acpi: check for pxm_to_node_map overflow |
| |
It is hardly (if ever) possible but in case of broken _PXM entry we could reach out of pxm_to_node_map array bounds in acpi_map_pxm_to_node() call.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> CC: Len Brown <lenb@kernel.org> ---
It's a patch resend. I didn't get any response on previous submission from Len, oh :(
Len is the patch really not needed or such a situation can't happen?
drivers/acpi/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/drivers/acpi/numa.c =================================================================== --- linux-2.6.git.orig/drivers/acpi/numa.c +++ linux-2.6.git/drivers/acpi/numa.c @@ -277,7 +277,7 @@ int acpi_get_node(acpi_handle *handle) int pxm, node = -1; pxm = acpi_get_pxm(handle); - if (pxm >= 0) + if (pxm >= 0 && pxm < MAX_PXM_DOMAINS) node = acpi_map_pxm_to_node(pxm); return node;
| |