lkml.org 
[lkml]   [2009]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
Ingo Molnar wrote:
> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Fri, 13 Feb 2009 13:36:47 +0100
> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
>

I think this is wrong in principle. There should never be a reason to
include a non-_types.h into asm.

(Fine as a build fix, of course.)

J

> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/include/asm/page_32.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/page_32.h b/arch/x86/include/asm/page_32.h
> index b3f0bf7..da4e762 100644
> --- a/arch/x86/include/asm/page_32.h
> +++ b/arch/x86/include/asm/page_32.h
> @@ -3,6 +3,8 @@
>
> #include <asm/page_32_types.h>
>
> +#ifndef __ASSEMBLY__
> +
> #ifdef CONFIG_HUGETLB_PAGE
> #define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
> #endif
> @@ -19,8 +21,6 @@ extern unsigned long __phys_addr(unsigned long);
> #define pfn_valid(pfn) ((pfn) < max_mapnr)
> #endif /* CONFIG_FLATMEM */
>
> -#ifndef __ASSEMBLY__
> -
> #ifdef CONFIG_X86_USE_3DNOW
> #include <asm/mmx.h>
>
>
>



\
 
 \ /
  Last update: 2009-02-13 19:47    [W:0.060 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site