lkml.org 
[lkml]   [2009]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] x86 headers: include linux/types.h

Regarding the fixlet below - wouldnt PTE_FLAGS_MASK be better placed in
pgtable_types.h ? It's specifically related to the pte format. OTOH we
have a lot of PTE details in the page_*types.h files already.

The boundary between page_types.h and pgtable_types.h does not seem to
be clear to me - what is the principle you followed?

Ingo

----------------------->
From e43623b4ed1d0a1a86f0e05a2df8b9637b90ddd7 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 13 Feb 2009 13:24:19 +0100
Subject: [PATCH] x86 headers: include page_types.h in pgtable_types.h
To properly pick up details like PTE_FLAGS_MASK.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/include/asm/pgtable_types.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/pgtable_types.h b/arch/x86/include/asm/pgtable_types.h
index a7452f1..9dafe87 100644
--- a/arch/x86/include/asm/pgtable_types.h
+++ b/arch/x86/include/asm/pgtable_types.h
@@ -2,6 +2,7 @@
#define _ASM_X86_PGTABLE_DEFS_H

#include <linux/const.h>
+#include <asm/page_types.h>

#define FIRST_USER_ADDRESS 0


\
 
 \ /
  Last update: 2009-02-13 13:29    [from the cache]
©2003-2011 Jasper Spaans