Messages in this thread | | | Date | Wed, 09 Dec 2009 15:14:59 +0800 | From | Lai Jiangshan <> | Subject | [PATCH V4 0/10] tracing: use defined fields to print formats |
| |
It seems that ftrace_format_##call() and ftrace_define_fields_##call() are duplicate more or less.
trace_define_field() defines fields and links them into strcut ftrace_event_call. We reuse them to print formats and remove ftrace_format_##call(). It make all things simpler.
Quote(From Steven): """ I totally agree that your patch is a nice clean up, and saves space and prevents more bugs. On the other hand, we are changing an API to users where all tools that parse this must be able to cope. """
But now, this new patchset does not change any API to userspace. PATCH#1 fix a mistake of trace_kprobe's format. You can
1) apply PATCH#1, compile, reboot with new kernel, add kprobe_events, save all the format files.
2) apply PATCH#2...10 additionally, compile, reboot with new kernel, add kprobe_events, save all the format files.
Take diffs of these two sets of format files, there are nothing changed.
So, this patchset does not change any API.
And this patchset does a nice cleanup and removes hunk of codes: # size vmlinux.o.old vmlinux.o text data bss dec hex filename 5640127 589938 1299464 7529529 72e439 vmlinux.o.old 5620506 589938 1298888 7509332 729554 vmlinux.o
Patches are partitioned for easy to review: PATCH#1~5 prepare (PATCH#2 fix a regression) PATCH#6 add "print_fmt" field to struct ftrace_event_call and and initialization code for it. PATCH#7 "print_fmt" initialization code for trace_syscalls PATCH#8 "print_fmt" initialization code for trace_kprobe PATCH#9 use defined fields and "print_fmt" to print formats PATCH#10 remove show_format and corresponding codes.
This patchset is ready for 2.6.33.
This patchset is applied upon Li Zefan's patchset: [PATCH 00/13] tracing: various cleanups and small fixes (updated). Because this patchset depends on [PATCH 01/13] and [PATCH 03/13] of this patchset.
But if [PATCH 01/13] of Li Zefan's is not applied, it's OK that just don't apply PATCH#3 of mine.
If [PATCH 03/13] of Li Zefan's is not applied, you should apply Frederic's [GIT PULL] tracing/kprobes: Fix field creation's bad error handling Because my patchset rely correct fields.
Lai
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> --- include/linux/ftrace_event.h | 3 include/linux/syscalls.h | 8 -- include/trace/ftrace.h | 168 +++++++++--------------------------------- include/trace/syscall.h | 4 - kernel/trace/trace_events.c | 71 ++++++++--------- kernel/trace/trace_export.c | 94 ++++------------------- kernel/trace/trace_kprobe.c | 100 +++++++++---------------- kernel/trace/trace_syscalls.c | 94 +++++++++++------------ 8 files changed, 176 insertions(+), 366 deletions(-)
| |