Messages in this thread Patch in this message | | | Date | Wed, 9 Dec 2009 20:25:23 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 10/12] drivers/usb: Correct size given to memset |
| |
From: Julia Lawall <julia@diku.dk>
Memset should be given the size of the structure, not the size of the pointer.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ type T; T *x; expression E; @@
memset(x, E, sizeof( + * x)) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/usb/gadget/f_mass_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c @@ -2675,7 +2675,7 @@ static struct fsg_common *fsg_common_ini return ERR_PTR(-ENOMEM); common->free_storage_on_release = 1; } else { - memset(common, 0, sizeof common); + memset(common, 0, sizeof *common); common->free_storage_on_release = 0; }
| |