Messages in this thread Patch in this message | | | Date | Mon, 07 Dec 2009 03:53:30 +0000 | Subject | [PATCH 10/19] Kill ancient crap in s390 compat mmap | From | Al Viro <> |
| |
We've had TASK_SIZE set to 1<<31 for 31bit tasks since May 2004. Before that old32_mmap() had to deal with do_mmap_pgoff() giving it an address out of range. It had tried to do that by checking return value and doing do_munmap() (at wrong address, BTW).
IOW, that code had been dead for 5.5 years (and bogus - for 8). Kill.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- arch/s390/kernel/compat_linux.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c index 0debcec..c5a9fba 100644 --- a/arch/s390/kernel/compat_linux.c +++ b/arch/s390/kernel/compat_linux.c @@ -701,11 +701,6 @@ static inline long do_mmap2( down_write(¤t->mm->mmap_sem); error = do_mmap_pgoff(file, addr, len, prot, flags, pgoff); - if (!IS_ERR((void *) error) && error + len >= 0x80000000ULL) { - /* Result is out of bounds. */ - do_munmap(current->mm, addr, len); - error = -ENOMEM; - } up_write(¤t->mm->mmap_sem); if (file) -- 1.5.6.5
| |