Messages in this thread | | | Date | Sun, 27 Dec 2009 22:51:06 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/5] arch/arm: Correct NULL test |
| |
On Sun, Dec 27, 2009 at 10:26:54PM +0100, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Test the just-allocated value for NULL rather than some other value. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > .... > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > arch/arm/plat-pxa/dma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/arch/arm/plat-pxa/dma.c b/arch/arm/plat-pxa/dma.c > --- a/arch/arm/plat-pxa/dma.c > +++ b/arch/arm/plat-pxa/dma.c > @@ -244,7 +244,7 @@ static void pxa_dma_init_debugfs(void) > > dbgfs_chan = kmalloc(sizeof(*dbgfs_state) * num_dma_channels, > GFP_KERNEL); > - if (!dbgfs_state) > + if (!dbgfs_chan) > goto err_alloc; Shouldn't the malloc line read:
... = kmalloc(sizeof(*dbgfs_chan) * ...) ^^^^^^^^^^
?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |