Messages in this thread Patch in this message | | | Date | Sun, 27 Dec 2009 22:26:54 +0100 (CET) | From | Julia Lawall <> | Subject | [PATCH 1/5] arch/arm: Correct NULL test |
| |
From: Julia Lawall <julia@diku.dk>
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression x,y; statement S; @@
x = \(kmalloc\|kcalloc\|kzalloc\)(...); ( if ((x) == NULL) S | if ( - y + x == NULL) S ) // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- arch/arm/plat-pxa/dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/arch/arm/plat-pxa/dma.c b/arch/arm/plat-pxa/dma.c --- a/arch/arm/plat-pxa/dma.c +++ b/arch/arm/plat-pxa/dma.c @@ -244,7 +244,7 @@ static void pxa_dma_init_debugfs(void) dbgfs_chan = kmalloc(sizeof(*dbgfs_state) * num_dma_channels, GFP_KERNEL); - if (!dbgfs_state) + if (!dbgfs_chan) goto err_alloc; chandir = debugfs_create_dir("channels", dbgfs_root);
| |