lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ep93xx_eth.c: general cleanup
On Wed, Dec 16, 2009 at 01:06:10PM -0500, H Hartley Sweeten wrote:

> >> General cleanup of the ep93xx_eth driver.
> >
> > Apart from keeping DRV_MODULE_NAME and DRV_MODULE_VERSION, I have
> > no strong opinion about this one way or the other. So I guess that
> > means ACK.
>
> I will add back the DRV_MODULE_NAME and DRV_MODULE_VERSION and repost.
>
> What about the message in ep93xx_eth_init_module()? Would you prefer
> that one to stay?

Most drivers I'm familiar with print a version message when they are
first instantiated -- perhaps that makes more sense.


\
 
 \ /
  Last update: 2009-12-16 19:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site