Messages in this thread | | | Date | Wed, 16 Dec 2009 19:08:49 +0100 | From | Lennert Buytenhek <> | Subject | Re: [PATCH] ep93xx_eth.c: general cleanup |
| |
On Wed, Dec 16, 2009 at 01:06:10PM -0500, H Hartley Sweeten wrote:
> >> General cleanup of the ep93xx_eth driver. > > > > Apart from keeping DRV_MODULE_NAME and DRV_MODULE_VERSION, I have > > no strong opinion about this one way or the other. So I guess that > > means ACK. > > I will add back the DRV_MODULE_NAME and DRV_MODULE_VERSION and repost. > > What about the message in ep93xx_eth_init_module()? Would you prefer > that one to stay?
Most drivers I'm familiar with print a version message when they are first instantiated -- perhaps that makes more sense.
| |