Messages in this thread |  | | | Subject | RE: [PATCH] ep93xx_eth.c: general cleanup | | Date | Wed, 30 Dec 2009 13:03:00 -0500 | | From | "H Hartley Sweeten" <> |
| |
On Wednesday, December 23, 2009 3:15 PM, David Miller wrote: > From: "H Hartley Sweeten" <hartleys@visionengravers.com> > Date: Wed, 16 Dec 2009 13:34:55 -0500 > >> Wednesday, December 16, 2009 11:32 AM, Lennert Buytenhek wrote: >>> On Wed, Dec 16, 2009 at 01:18:13PM -0500, H Hartley Sweeten wrote: >>> >>>> V3 - Change pr_fmt() as suggested by Joe Perches >>>> Don't remove DRV_MODULE_NAME and DRV_MODULE_VERSION >>>> Don't remove the message in ep93xx_eth_init_module() >>> >>> That's not what I meant, but alright, as you prefer. >> >> Guess my parser is off line today.... ;-) >> >> What did you mean? > > This patch also doesn't apply to current sources, so if you > could also please respin this once you've resolved the feedback > that would be great.
Lennert,
Since I need to respin this patch what did you mean by this comment?
On Wednesday, December 16, 2009 11:09 AM, Lennert Buytenhek wrote: > On Wed, Dec 16, 2009 at 01:06:10PM -0500, H Hartley Sweeten wrote: > >>>> General cleanup of the ep93xx_eth driver. >>> >>> Apart from keeping DRV_MODULE_NAME and DRV_MODULE_VERSION, I have >>> no strong opinion about this one way or the other. So I guess that >>> means ACK. >> >> I will add back the DRV_MODULE_NAME and DRV_MODULE_VERSION and repost. >> >> What about the message in ep93xx_eth_init_module()? Would you prefer >> that one to stay? > > Most drivers I'm familiar with print a version message when they are > first instantiated -- perhaps that makes more sense.
I will wait for your reply before updating the patch.
Thanks, Hartley
|  |