Messages in this thread | | | Date | Mon, 30 Nov 2009 21:58:13 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger |
| |
On Mon, Nov 30, 2009 at 12:45:20PM -0600, Madhusudhan wrote: [...] > > + case POWER_SUPPLY_PROP_VOLTAGE_NOW: > > + /* charging must be active for meaningful result */ > > + if (!is_charging) { > > How about putting a kern_info here?
It might be better to return -EINVAL.
Thanks!
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2
| |