Messages in this thread | | | Date | Wed, 2 Dec 2009 22:38:31 +0200 | Subject | Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger | From | Grazvydas Ignotas <> |
| |
On Mon, Nov 30, 2009 at 8:58 PM, Anton Vorontsov <avorontsov@ru.mvista.com> wrote: > On Mon, Nov 30, 2009 at 12:45:20PM -0600, Madhusudhan wrote: > [...] >> > + case POWER_SUPPLY_PROP_VOLTAGE_NOW: >> > + /* charging must be active for meaningful result */ >> > + if (!is_charging) { >> >> How about putting a kern_info here? > > It might be better to return -EINVAL.
That causes lots of warnings from power_supply core (driver failed to report XXX property), Not sure what to do here, I'd prefer to keep returning 0.
> > Thanks! > > -- > Anton Vorontsov > email: cbouatmailru@gmail.com > irc://irc.freenode.net/bd2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |