Messages in this thread | | | Date | Thu, 19 Nov 2009 15:38:36 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH 3/3] macvlan: export macvlan mode through netlink |
| |
Arnd Bergmann wrote: > On Wednesday 18 November 2009, Eric Dumazet wrote: >>> --- a/drivers/net/macvlan.c >>> +++ b/drivers/net/macvlan.c >>> @@ -33,12 +33,6 @@ >>> >>> #define MACVLAN_HASH_SIZE (1 << BITS_PER_BYTE) >>> >>> -enum macvlan_type { >>> - MACVLAN_PRIVATE = 1, >>> - MACVLAN_VEPA = 2, >>> - MACVLAN_BRIDGE = 4, >>> -}; >> I realize you defined MACVLAN_PRIVATE in patch 2, but used MACVLAN_MODE_PRIVATE, >> so patch 2 is not compilable and breaks bisection ? >> > > Hmm, right. I'll fix that up as well.
> +enum ifla_macvlan_mode { > + MACVLAN_MODE_PRIVATE = 1, /* don't talk to other macvlans */ > + MACVLAN_MODE_VEPA = 2, /* talk to other ports through ext bridge */ > + MACVLAN_MODE_BRIDGE = 4, /* talk to bridge ports directly */ > +};
Please also keep the enum named something without ifla_ since the mode values themselves are not netlink attributes. Just macvlan_mode seems fine.
| |