Messages in this thread |  | | | From | Arnd Bergmann <> | | Subject | Re: [PATCH 3/3] macvlan: export macvlan mode through netlink | | Date | Thu, 19 Nov 2009 15:47:03 +0100 |
| |
On Thursday 19 November 2009, Patrick McHardy wrote: > > +enum ifla_macvlan_mode { > > + MACVLAN_MODE_PRIVATE = 1, /* don't talk to other macvlans */ > > + MACVLAN_MODE_VEPA = 2, /* talk to other ports through ext bridge */ > > + MACVLAN_MODE_BRIDGE = 4, /* talk to bridge ports directly */ > > +}; > > Please also keep the enum named something without ifla_ since > the mode values themselves are not netlink attributes. Just > macvlan_mode seems fine.
Ok, good. I was unsure on the naming and also changed between MACVLAN_* and MACVLAN_MODE_* a few times.
Thanks for the clarification,
Arnd <><
|  |