Messages in this thread | | | Date | Wed, 18 Nov 2009 11:32:34 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH -tip 0/3] tracepoint: Add signal events |
| |
Roland McGrath wrote: > I would add the siginfo_t * argument to each of these tracepoints.
I see. Is it OK to record only si_errno and si_code? because si_signo might be as same as sig.
> In 2/3 this comment: > > + /* Trace the actual delivered signals including SIG_IGN.*/ > > might be slightly misleading. In most cases SIG_IGN signals won't make it > this far. The same is true of SIG_DFL signals whose default action is to > ignore. So one should be clear that trace_signal_deliver() is by no means > expected to get all SIG_IGN signals that are otherwise eligible for delivery.
Ah, thank you for noticing. I'll remove the last words.
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |