lkml.org 
[lkml]   [2009]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip 0/3] tracepoint: Add signal events
Roland McGrath wrote:
> I would add the siginfo_t * argument to each of these tracepoints.

I see. Is it OK to record only si_errno and si_code? because si_signo
might be as same as sig.

> In 2/3 this comment:
>
> + /* Trace the actual delivered signals including SIG_IGN.*/
>
> might be slightly misleading. In most cases SIG_IGN signals won't make it
> this far. The same is true of SIG_DFL signals whose default action is to
> ignore. So one should be clear that trace_signal_deliver() is by no means
> expected to get all SIG_IGN signals that are otherwise eligible for delivery.

Ah, thank you for noticing. I'll remove the last words.

Thank you,

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2009-11-18 17:35    [W:0.058 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site