Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH -tip 0/3] tracepoint: Add signal events | Date | Tue, 17 Nov 2009 19:07:06 -0800 (PST) |
| |
I would add the siginfo_t * argument to each of these tracepoints.
In 2/3 this comment:
+ /* Trace the actual delivered signals including SIG_IGN.*/
might be slightly misleading. In most cases SIG_IGN signals won't make it this far. The same is true of SIG_DFL signals whose default action is to ignore. So one should be clear that trace_signal_deliver() is by no means expected to get all SIG_IGN signals that are otherwise eligible for delivery.
Thanks, Roland
| |