Messages in this thread Patch in this message | | | From | steve@digidesc ... | Subject | [PATCH, RESEND] microblaze: Fix level interrupt ACKing | Date | Tue, 17 Nov 2009 08:43:39 -0600 |
| |
Level interrupts need to be ack'd in the unmask handler, as in powerpc. Among other issues, this bug causes the system clock to appear to run at double-speed.
Signed-off-by: Steven J. Magnani <steve@digidescorp.com> --- diff -uprN a/arch/microblaze/kernel/intc.c b/arch/microblaze/kernel/intc.c --- a/arch/microblaze/kernel/intc.c 2009-06-02 15:26:28.000000000 -0500 +++ b/arch/microblaze/kernel/intc.c 2009-06-02 15:27:39.000000000 -0500 @@ -41,8 +41,16 @@ unsigned int nr_irq; static void intc_enable_or_unmask(unsigned int irq) { + unsigned long mask = 1 << irq; pr_debug("enable_or_unmask: %d\n", irq); - out_be32(INTC_BASE + SIE, 1 << irq); + out_be32(INTC_BASE + SIE, mask); + + /* ack level irqs because they can't be acked during + * ack function since the handle_level_irq function + * acks the irq before calling the interrupt handler + */ + if (irq_desc[irq].status & IRQ_LEVEL) + out_be32(INTC_BASE + IAR, mask); } static void intc_disable_or_mask(unsigned int irq)
| |