lkml.org 
[lkml]   [2009]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] perf tools: New function to parse string representing size in bytes
From
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v3] perf tools: New function to parse string representing size in bytes
Date: Sun, 15 Nov 2009 12:04:32 +0100

>
> * Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
>
> > > > + length = atoll(str) * unit;
> > >
> > > we might want to take a naming clue here and name this new function as
> > > atoll_exp(), to signal that it works like atoll, just with an extension
> > > for KB/MB/GB/etc. expressions?
> >
> > Hm, how about "atoll_byteunit()"?
> > This may have no ambiguity.
>
> I'd suggest to name it in a generic way, in case we want to add other
> convenience conversions, hm?
>
> Perhaps simply perf_atoll() - an extended version that understands byte
> units (and potentially more in the future).

OK. I name the function perf_atoll().
I'll send the patch later.



\
 
 \ /
  Last update: 2009-11-15 12:37    [W:0.038 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site