Messages in this thread | | | Date | Sun, 15 Nov 2009 12:04:32 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v3] perf tools: New function to parse string representing size in bytes |
| |
* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> > > + length = atoll(str) * unit; > > > > we might want to take a naming clue here and name this new function as > > atoll_exp(), to signal that it works like atoll, just with an extension > > for KB/MB/GB/etc. expressions? > > Hm, how about "atoll_byteunit()"? > This may have no ambiguity.
I'd suggest to name it in a generic way, in case we want to add other convenience conversions, hm?
Perhaps simply perf_atoll() - an extended version that understands byte units (and potentially more in the future).
Ingo
| |