Messages in this thread | | | Subject | Re: [PATCH] net/atm: move all compat_ioctl handling to atm/ioctl.c | From | David Woodhouse <> | Date | Wed, 11 Nov 2009 13:34:50 +0000 |
| |
On Wed, 2009-11-11 at 14:30 +0100, Arnd Bergmann wrote: > > +struct atmif_sioc32 { > + compat_int_t number; > + compat_int_t length; > + compat_caddr_t arg; > +}; > + > +struct atm_iobuf32 { > + compat_int_t length; > + compat_caddr_t buffer; > +};
We already have compat_atmif_sioc and compat_atm_iobuf structures defined -- do those need to be duplicated?
Other than that, it looks sane. I wish I'd noticed that we already had half a COMPAT implementation when I added the new bits. Thanks.
-- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation
| |