lkml.org 
[lkml]   [2009]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3] net/atm: move all compat_ioctl handling to atm/ioctl.c
    From
    From: Arnd Bergmann <arnd@arndb.de>
    Date: Wed, 11 Nov 2009 14:45:22 +0100

    > We have two implementations of the compat_ioctl handling for ATM, the
    > one that we have had for ages in fs/compat_ioctl.c and the one added to
    > net/atm/ioctl.c by David Woodhouse. Unfortunately, both versions are
    > incomplete, and in practice we use a very confusing combination of the
    > two.
    >
    > For ioctl numbers that have the same identifier on 32 and 64 bit systems,
    > we go directly through the compat_ioctl socket operation, for those that
    > differ, we do a conversion in fs/compat_ioctl.c.
    >
    > This patch moves both variants into the vcc_compat_ioctl() function,
    > while preserving the current behaviour. It also kills off the COMPATIBLE_IOCTL
    > definitions that we never use here.
    > Doing it this way is clearly not a good solution, but I hope it is a
    > step into the right direction, so that someone is able to clean up this
    > mess for real.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Applied, thanks.


    \
     
     \ /
      Last update: 2009-11-12 04:59    [W:0.035 / U:2.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site