Messages in this thread | | | Date | Tue, 06 Oct 2009 00:01:35 +0900 | From | Tejun Heo <> | Subject | Re: [this_cpu_xx V4 12/20] Move early initialization of pagesets out of zone_wait_table_init() |
| |
Christoph Lameter wrote: > On Sat, 3 Oct 2009, Tejun Heo wrote: > >>> arch/ia64/kernel/setup.c | 1 + >>> arch/powerpc/kernel/setup_64.c | 1 + >>> arch/sparc/kernel/smp_64.c | 1 + >>> arch/x86/kernel/setup_percpu.c | 2 ++ >>> include/linux/mm.h | 1 + >>> mm/page_alloc.c | 40 +++++++++++++++++++++++++++++----------- >>> mm/percpu.c | 2 ++ >> Hmmm... why not call this function from start_kernel() after calling >> setup_per_cpu_areas() instead of modifying every implementation of >> setup_per_cpu_areas()? > > Because it has to be called immediately after per cpu areas become > available. Otherwise page allocator uses will fail.
But... setup_per_cpu_area() isn't supposed to call page allocator and start_kernel() is the only caller of setup_per_cpu_areas().
-- tejun
| |