Messages in this thread | | | Date | Tue, 06 Oct 2009 00:21:33 +0900 | From | Tejun Heo <> | Subject | Re: [this_cpu_xx V4 12/20] Move early initialization of pagesets out of zone_wait_table_init() |
| |
Christoph Lameter wrote: > On Tue, 6 Oct 2009, Tejun Heo wrote: > >>> Because it has to be called immediately after per cpu areas become >>> available. Otherwise page allocator uses will fail. >> But... setup_per_cpu_area() isn't supposed to call page allocator and >> start_kernel() is the only caller of setup_per_cpu_areas(). > > setup_per_cpu_areas() is not calling the page allocator. However, any > caller after that can call the page allocator. > > There are various arch implementations that do their own implementation of > setup_per_cpu_areas() at their own time (Check sparc and ia64 for > example).
sparc is doing everything on setup_per_cpu_areas(). ia64 is an exception. Hmmm... I really don't like scattering mostly unrelated init call to every setup_per_cpu_areas() implementation. How about adding "static bool initialized __initdata" to the function and allow it to be called earlier when necessary (only ia64 at the moment)?
Thanks.
-- tejun
| |