lkml.org 
[lkml]   [2009]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: keep index within bounds in da9034_get_ldo12_voltage()
From
Date
On Mon, 2009-10-26 at 12:37 +0100, Roel Kluin wrote:
> If selector equals ARRAY_SIZE(da9034_ldo12_data), that is one too
> large already.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/regulator/da903x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index aa224d9..f8c4661 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -331,7 +331,7 @@ static int da9034_get_ldo12_voltage(struct regulator_dev *rdev)
> static int da9034_list_ldo12_voltage(struct regulator_dev *rdev,
> unsigned selector)
> {
> - if (selector > ARRAY_SIZE(da9034_ldo12_data))
> + if (selector >= ARRAY_SIZE(da9034_ldo12_data))
> return -EINVAL;
> return da9034_ldo12_data[selector] * 1000;
> }

Applied.

Thanks

Liam



\
 
 \ /
  Last update: 2009-10-26 14:47    [W:0.022 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site