Messages in this thread | | | Subject | Re: [RFC Patch] use MTRR for write combining if PAT is not available | From | Suresh Siddha <> | Date | Mon, 19 Oct 2009 06:44:34 -0700 |
| |
On Mon, 2009-10-19 at 02:16 -0700, Jan Beulich wrote: > Functionality-wise this looks fine to me
If we are going to make ioremap() and set_memory_wc() add mtrr's in non-pat case, then we need to delete the added mtrr(s) in the corresponding iounmap() and set_memory_wb() aswell.
hmm, this is becoming too complex. The way i915 and other graphics drivers are using set_memory_wc(), it is def a bad idea to start adding mtrr's behind the back for non-pat case.
Can't we just force PAT option always and we probably don't care about ioremap_wc() on processors were PAT doesn't get enabled because of known errata.
or Perhaps just try to add mtrr only for the pci mmap case like the 4th patch in this series..
thanks, suresh
| |