lkml.org 
[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: powerpc: introduce asm/swab.h
    On Tue, 6 Jan 2009, Linus Torvalds wrote:

    >
    >
    > On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote:
    > >
    > > Even if fixing that to use __swab32() instead, then it fails because
    > > this is defined after it's used. I worked around it using fswab in
    > > there instead.
    >
    > That's the same patch I just sent out (but you changed comments too), so I
    > obviously agree.
    >
    > x86 didn't see this (even in 32-bit mode) because it doesn't use that odd
    > __SWAB_64_THRU_32__ case, but does the 64-bit swab with native code.
    >
    > Can you also verify that it works for you (not just compiles), just so
    > that I can commit it?

    Tested OK on ARM (using LE mode with networking, etc.)


    Nicolas


    \
     
     \ /
      Last update: 2009-01-07 06:21    [W:0.018 / U:120.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site