[lkml]   [2009]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: powerpc: introduce asm/swab.h

    On Wed, 7 Jan 2009, Nicolas Pitre wrote:

    > On Tue, 6 Jan 2009, Linus Torvalds wrote:
    > > On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote:
    > >
    > > Can you also verify that it works for you (not just compiles), just so
    > > that I can commit it?
    > Tested OK on ARM (using LE mode with networking, etc.)

    Ok, I committed it as a quick-fix. I'm not sure that is necessarily the
    final one, but at least it is better than not compiling.

    For example, it's kind of silly to use two __fswab32()'s with other
    oddness if that one just falls back on __constant_swab32: maybe we'd want
    to make sure that we'd use ___constant_swab64() in that case, and only do
    the whole __SWAB_64_THRU_32__ if we really have a __arch_swab32()

    Of course, I do hope that anybody who #defines __SWAB_64_THRU_32__ already
    has that __arch_swab32() thing, so it's likely fine.

    I also wonder whether gcc generates better code with a union than with
    that 64-bit math...


     \ /
      Last update: 2009-01-07 06:41    [W:0.021 / U:19.936 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site