Messages in this thread | | | From | Louis Rilling <> | Subject | [PATCH v2] Make lockdep happy with configfs | Date | Wed, 28 Jan 2009 19:18:31 +0100 |
| |
Hi Joel,
Here is a revised version of the patchset making lockdep happy with configfs. I still don't have a good setup to test the second patch beyond compilation, and I still guess that you have one :)
Louis
Changelog: - put s_depth logic in separate functions and remove #ifdef LOCKDEP in the hooked functions. - added the following note to explain why configfs_depend_prep() is correct when examining attaching items: + * Note: items in the middle of attachment start with s_type = 0 + * (configfs_new_dirent()), and configfs_make_dirent() (called from + * create_dir()) sets s_type = CONFIGFS_DIR|CONFIGFS_USET_CREATING. In both + * cases the item is ignored. Since s_type is an int, we rely on the CPU to + * atomically update the value, without making configfs_make_dirent() take + * configfs_dirent_lock.
- fixed parenthesis on pattern !a & b && c --> !(a & b) && c - quiet checkpatch
Louis Rilling (2): configfs: Silence lockdep on mkdir() and rmdir() configfs: Rework configfs_depend_item() locking and make lockdep happy
fs/configfs/configfs_internal.h | 3 + fs/configfs/dir.c | 188 ++++++++++++++++++++++++++++----------- fs/configfs/inode.c | 38 ++++++++ 3 files changed, 175 insertions(+), 54 deletions(-) -- Dr Louis Rilling Kerlabs Skype: louis.rilling Batiment Germanium Phone: (+33|0) 6 80 89 08 23 80 avenue des Buttes de Coesmes http://www.kerlabs.com/ 35700 Rennes
| |