Messages in this thread | | | Date | Tue, 13 Jan 2009 16:12:15 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h |
| |
[Jaswinder Singh Rajput - Tue, Jan 13, 2009 at 06:38:02PM +0530] | On Tue, Jan 13, 2009 at 6:27 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote: | > [Cyrill Gorcunov - Tue, Jan 13, 2009 at 03:09:05PM +0300] | > | Impact: cleanup | > | | > | 'make headers_check' warns that linux/types.h is | > | preferred over asm/types.h. So be it. | > | | > | Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> | > | CC: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> | > | CC: Sam Ravnborg <sam@ravnborg.org> | > | CC: Harvey Harrison <harvey.harrison@gmail.com> | > | --- | > | | > | arch/x86/include/asm/e820.h | 2 ++ | > | arch/x86/include/asm/kvm.h | 2 +- | > | arch/x86/include/asm/mce.h | 2 +- | > | arch/x86/include/asm/mtrr.h | 1 + | > | arch/x86/include/asm/ptrace-abi.h | 2 +- | > | arch/x86/include/asm/sigcontext.h | 2 +- | > | arch/x86/include/asm/swab.h | 2 +- | > | 7 files changed, 8 insertions(+), 5 deletions(-) | > | | > ... | > | > well... on the other hand I'm not sure if it's really | > a good idea to include linux/types.h where we need only | > __u[8,16] and so on definitions. | > | > Ingo, don't apply this patch please -- have to check | > for other ways. | > | | I am attaching usr/include/linux/types.h for your reference which | includes all these definations for userspace. | | Thanks | -- | JSR
yeah, thanks! I already have one in my git clone but anyway ;-)
- Cyrill -
| |