Messages in this thread | | | Date | Tue, 13 Jan 2009 16:25:28 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH -tip] x86: headers - include linux/types.h instead of asm/types.h |
| |
[Cyrill Gorcunov - Tue, Jan 13, 2009 at 04:10:20PM +0300] ... | | > | | > well... on the other hand I'm not sure if it's really | | > a good idea to include linux/types.h where we need only | | > __u[8,16] and so on definitions. | | | | Well, linux/types.h is supposed to be a 'lightweight', 'core data types | | only' kind of header file, so including it is not wrong per se. | | | | Sam, is there some other preferred way perhaps to resolve these? | | | | Ingo | | | | Until such a file not passed to some *.S. For example for e820.h | we have it included to arch/x86/boot/header.S but fortunately | we're bound by __ASSEMBLY__. So there linux/types.h shouldn't hurt. | Will check others and report then. | | - Cyrill -
ok, have checked -- this patch seems to be safe.
- Cyrill -
| |