lkml.org 
[lkml]   [2009]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] [RFC] remove (more or less) unnecessary cacheline_aligned from module_ref
On x86_64 systems with CONFIG_MAXSMP set, NR_CPUS is exploded to 4096
cpus. This cacheline_aligned attribute on the local_t in module_ref
results in struct module bloating to over 512KB in size on x86_64, which
tends to, er, add up. This results in insane disk usage on distro
kernel configs (1GB+ on Fedora.)

Killing cacheline_aligned reduces the size of struct module to somewhat
more sane levels.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
---
I'll followup with a patch to make mod->ref dynamically allocated, but
that needs a bit more thinking because module_unload_init currently
doesn't have a failure path.

Of course, reducing NR_CPUS to something sane was an easy way to patch
over the problem.

diff --git a/include/linux/module.h b/include/linux/module.h
index 4f7ea12..32b0bda 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -222,7 +222,7 @@ void *__symbol_get_gpl(const char *symbol);
struct module_ref
{
local_t count;
-} ____cacheline_aligned;
+};

enum module_state
{

\
 
 \ /
  Last update: 2009-01-12 04:27    [W:0.034 / U:1.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site