Messages in this thread | | | Date | Fri, 26 Sep 2008 14:59:48 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 3/12] memcg make root cgroup unlimited. |
| |
KAMEZAWA Hiroyuki wrote: > On Fri, 26 Sep 2008 14:11:00 +0530 > Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > >> KAMEZAWA Hiroyuki wrote: >>> Make root cgroup of memory resource controller to have no limit. >>> >>> By this, users cannot set limit to root group. This is for making root cgroup >>> as a kind of trash-can. >>> >>> For accounting pages which has no owner, which are created by force_empty, >>> we need some cgroup with no_limit. A patch for rewriting force_empty will >>> will follow this one. >>> >>> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >> This is an ABI change (although not too many people might be using it, I wonder >> if we should add memory.features (a set of flags and let users enable them and >> provide good defaults), like sched features. >> > I think "feature" flag is complicated, at this stage. > We'll add more features and not settled yet. >
I know.. but breaking ABI is a bad bad thing. We'll have to keep the feature flags extensible (add new things). If we all feel we don't have enough users affected by this change, I might agree with you and make that change.
> Hmm, if you don't like this, > calling try_to_free_page() at force_empty() instead of move_account() ? >
Not sure I understand this.
-- Balbir
| |