Messages in this thread | | | Date | Fri, 26 Sep 2008 18:59:44 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 3/12] memcg make root cgroup unlimited. |
| |
On Fri, 26 Sep 2008 14:59:48 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > I think "feature" flag is complicated, at this stage. > > We'll add more features and not settled yet. > > > > I know.. but breaking ABI is a bad bad thing. We'll have to keep the feature > flags extensible (add new things). If we all feel we don't have enough users > affected by this change, I might agree with you and make that change. > Hmm...I'll drop this and add force_empty_may_fail logic in changes in force_empty.
> > Hmm, if you don't like this, > > calling try_to_free_page() at force_empty() instead of move_account() ? > > > > Not sure I understand this. > In following series, force_empty() uses move_account() rather than forget all. By this, accounted file caches are kept as accounted and the whole accounting will be sane.
Another choice is calling try_to_free_pages() at force_empty rather than forget all and makes memory usage to be Zero. This will also makes the whole accounting sange.
Thanks, -Kame
| |