lkml.org 
[lkml]   [2008]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] olpc: fix endian bug in openfirmware workaround
    From
    Date
    Boardrev is always treated as a u32 everywhere else, no reason to
    byteswap the 0xc2 value. The only use is to print out if it is
    a prerelease board, the test being:

    (olpc_platform_info.boardrev & 0xf) < 8

    Which is currently always true as be32_to_cpu(0xc2) & 0xf = 0
    but I doubt that was the intention here. The consequences of the bug
    are pretty minor though (incorrect boardrev displayed in dmesg when
    ofw support not configured)

    Also annotate the temporary used to read the boardrev in the ofw
    case.

    The confusion was noticed by sparse:
    arch/x86/kernel/olpc.c:206:32: warning: cast to restricted __be32

    Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
    ---
    arch/x86/kernel/olpc.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/olpc.c b/arch/x86/kernel/olpc.c
    index 3e66722..7a13fac 100644
    --- a/arch/x86/kernel/olpc.c
    +++ b/arch/x86/kernel/olpc.c
    @@ -190,12 +190,12 @@ EXPORT_SYMBOL_GPL(olpc_ec_cmd);
    static void __init platform_detect(void)
    {
    size_t propsize;
    - u32 rev;
    + __be32 rev;

    if (ofw("getprop", 4, 1, NULL, "board-revision-int", &rev, 4,
    &propsize) || propsize != 4) {
    printk(KERN_ERR "ofw: getprop call failed!\n");
    - rev = 0;
    + rev = cpu_to_be32(0);
    }
    olpc_platform_info.boardrev = be32_to_cpu(rev);
    }
    @@ -203,7 +203,7 @@ static void __init platform_detect(void)
    static void __init platform_detect(void)
    {
    /* stopgap until OFW support is added to the kernel */
    - olpc_platform_info.boardrev = be32_to_cpu(0xc2);
    + olpc_platform_info.boardrev = 0xc2;
    }
    #endif

    --
    1.6.0.2.471.g47a76




    \
     
     \ /
      Last update: 2008-09-24 00:23    [W:0.023 / U:0.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site