Messages in this thread | | | Date | Tue, 16 Sep 2008 11:31:57 +0100 | From | Ben Dooks <> | Subject | Re: wdt285: fix sparse warnings |
| |
On Mon, Sep 15, 2008 at 10:05:56AM +0200, Wim Van Sebroeck wrote: > Ben, > > ... > > @@ -141,13 +141,13 @@ static long watchdog_ioctl(struct file * > > switch (cmd) { > > case WDIOC_GETSUPPORT: > > ret = 0; > > - if (copy_to_user((void *)arg, &ident, sizeof(ident))) > > + if (copy_to_user((void __user *)arg, &ident, sizeof(ident))) > > ret = -EFAULT; > > break; > > > ... > > Isn't it better to fix this like we did with the other watchdog drivers: > void __user *argp = (void __user *)arg; > int __user *p = argp;
I've changed the int pointer, as it is used numerous times, but left the void as it is only used in the copy_to_user. ... > if (copy_to_user(argp, &ident, sizeof(ident))) > ... > > Regards, > Wim. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
| |