lkml.org 
[lkml]   [2008]   [Sep]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateMon, 15 Sep 2008 10:05:56 +0200
FromWim Van Sebroeck <>
SubjectRe: wdt285: fix sparse warnings
Ben,

...
> @@ -141,13 +141,13 @@ static long watchdog_ioctl(struct file *
>  	switch (cmd) {
>  	case WDIOC_GETSUPPORT:
>  		ret = 0;
> -		if (copy_to_user((void *)arg, &ident, sizeof(ident)))
> +		if (copy_to_user((void __user *)arg, &ident, sizeof(ident)))
>  			ret = -EFAULT;
>  		break;
> 
...

Isn't it better to fix this like we did with the other watchdog drivers:
        void __user *argp = (void __user *)arg;
        int __user *p = argp;
	...
		if (copy_to_user(argp, &ident, sizeof(ident)))
	...
Regards,
Wim.



\
 
 \ /
  Last update: 2008-09-15 10:09    [from the cache]
©2003-2008