Messages in this thread | | | Date | Tue, 5 Aug 2008 23:06:15 +0100 | From | Russell King <> | Subject | Re: kbuild now support arch/$ARCH/include - time for ARCHs to convert |
| |
On Tue, Aug 05, 2008 at 10:45:48PM +0200, Sam Ravnborg wrote: > On Tue, Aug 05, 2008 at 02:18:05PM +1000, Rusty Russell wrote: > > On Tuesday 29 July 2008 06:05:00 Sam Ravnborg wrote: > > > is is suggested to move the arch specific files under arch/ > > > and for the header files this is arch/$ARCH/include. > > > > Well, it would have been nice to take the opportunity to separate user-visible > > header files and non-user-visible files. We could have left the user-visible > > ones in place, for example: diffstat would then show when you were frobbing > > the userspace interface. > > I would like to see this change too - but intentionally I would > not try to mix it with the move of the header files. Lets get the > move done now and fix the fall-outs, then we can take this logical > next step.
Absolutely agreed.
Some architectures (eg, ARM) have quite a large headache to solve with these changes.
Currently, I know Linus' tree builds fine for most ARM platforms (thanks to the ARM kautobuild project.) However, I'm seeing unexpected build failures that don't make sense from the linux-next project.
I've just wound my tree back to a "pristine" state for linux-next, and plan to wait for its next build to check whether its me or something else causing it. What I'm referring to is:
s3c2410_defconfig's showing: include/asm/arch/map.h:16:30: error: asm/plat-s3c/map.h: No such file or directory
which, if its including it via include/ shouldn't be happening because plat-s3c hasn't moved from include/asm(-arm)/, the same as include/asm-arm/arch-s3c2410 hasn't moved in linux-next yet.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
| |