lkml.org 
[lkml]   [2008]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] pata_legacy: export functionality to ide
Date
On Sunday 03 August 2008, Alan Cox wrote:
> On Sun, 3 Aug 2008 09:37:56 +0200
> Borislav Petkov <petkovbb@googlemail.com> wrote:
>
> > Ok, here's a definitely better solution:
>
> Please don't stuff large important pieces of code in header files where
> they will be overlooked
>
> NAK this.
>
> I'm happy to have a shared library directory for ATA stuff, containing
> useful C code, but hiding stuff in headers like that is just plain wrong.

The code in question is 65 LOC total (43 LOC without counting comments)
so having a shared library just for it sounds like an overkill and we may
just copy that one function from pata_legacy to ide_generic instead.

Jeff, what is your stance here?


\
 
 \ /
  Last update: 2008-08-03 15:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site