Messages in this thread | | | Date | Sun, 03 Aug 2008 19:43:43 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH 1/2] pata_legacy: export functionality to ide |
| |
Alan Cox wrote: >> The code in question is 65 LOC total (43 LOC without counting comments) >> so having a shared library just for it sounds like an overkill and we may > > People expect code in C files, so in headers it gets missed as well as > dumped in a directory with no correlation between file name and subsystem. > >> just copy that one function from pata_legacy to ide_generic instead. > > If you are going to #include two copies you might as well just copy it.
That's pretty much my feeling... just copy the code.
If the shared code grows larger, create a kernel module with the stuff shared by both libata and drivers/ide.
liblibata? libata-core-core? :)
Jeff
| |