lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tipc: Use the appropriate swab helper rather than an internal helper
From
From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 12 Aug 2008 21:20:17 -0700

> On Tue, 12 Aug 2008 21:05:47 -0700 Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > ___generally means I am an internal implementation detail, don't use
> > me.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > Sorry for breaking the build Andrew, my testing has been with all the __constant
> > versions in-tree removed.
> >
> > net/tipc/subscr.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c
> > index 0326d30..f5da05d 100644
> > --- a/net/tipc/subscr.c
> > +++ b/net/tipc/subscr.c
> > @@ -85,7 +85,7 @@ static struct top_srv topsrv = { 0 };
> >
> > static u32 htohl(u32 in, int swap)
> > {
> > - return swap ? (u32)___constant_swab32(in) : in;
> > + return swap ? (u32)swab32(in) : in;
> > }
>
> yes, that's what I did too, only I dropped the
> seems-to-me-to-be-unneeded (u32) cast.

I've applied Andrew's patch.


\
 
 \ /
  Last update: 2008-08-13 11:35    [W:0.788 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site